Conversation
[#172588932] Authored-by: Jaskanwal Pawar <jpawar@pivotal.io>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/172829445 The labels on this github issue will be updated when the story is started. |
cwlbraa
reviewed
May 13, 2020
Contributor
|
May be overkill, but I think it would be nice to be explicit about what we expect the class names to be, and what folder we expect them to be in. I'm thinking something along the lines of https://github.com/cloudfoundry/cloud_controller_ng/wiki/Notes-on-V3-Architecture. |
selzoc
reviewed
May 28, 2020
selzoc
reviewed
May 28, 2020
tcdowney
reviewed
Jun 25, 2020
| accepts JSON form of any Kubernetes resource and simply propagates the desired | ||
| resource to the Kubernetes API. This single, generic client should also continue | ||
| to provide elegant, traceable error handling at least as well as we currently | ||
| do in the existing `route_crd_client` and the `kpack_client`. |
Member
There was a problem hiding this comment.
at least as well
Hopefully better. :) We weren't able to troubleshoot some issues in our environments with the current logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review and comment thx