Add deployable property to revisions endpoints.#1611
Merged
sethboyles merged 1 commit intomasterfrom May 27, 2020
Merged
Conversation
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/172864886 The labels on this github issue will be updated when the story is started. |
|
|
Member
Author
|
Hey @bm5w, sorry for the inconvenience--I cannot merge this unless you sign the CLA. Would you like to sign it? If you don't want to, we can re-do this work in a new PR. |
Contributor
|
@sethboyles I filled out the CLA. Let me know if I need to do something else. |
* Also allow filtering by deployable on revisions list [#171637275] Co-authored-by: Seth Boyles <sboyles@pivotal.io> Co-authored-by: Mark Saiget <saiget@gmail.com>
sethboyles
force-pushed
the
171637275_add_deployable_revisions
branch
from
d8cb82a to
9accf60
Compare
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/172986170 The labels on this github issue will be updated when the story is started. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meant to resolve #1567
@ssisil @selzoc @JenGoldstrich Wanted to get feedback on this solution since it's a little different from the issue's suggested solution.
Instead of a
statusproperty, this PR just surfaces adeployableproperty which indicates whether or not the revision can be rolled back to (i.e. the droplet is in the STAGED state).We were hesitant to introduce
state: DEPLOYEDbecause that implies around whether or not the process is actually started. Two revisions may also beDEPLOYEDat the same time (during rolling deployments)--it doesn't necessarily indicate which revision is the "current" revision. So we weren't sure if we should go down the path of figuring out if we needed to add states likeDEPLOYED_AND_CURRENT,DEPLOYED_AND_NOT_CURRENT,state: NOT_DEPLOYED_AND_CURRENT, etc if being able to tell if a revision could be used to create a deployment would was the main use case here.We can also consider adding a
currentanddeployedflag.TODO: