Fix task completion callback on k8s#1724
Merged
selzoc merged 1 commit intocloudfoundry:masterfrom Jul 7, 2020
Merged
Conversation
When deployed on K8s, Istio handles transparently applying mTLS to network traffic. [#173393442] Signed-off-by: Giuseppe Capizzi <gcapizzi@pivotal.io>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/173666642 The labels on this github issue will be updated when the story is started. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deployed on K8s, Istio handles transparently applying mTLS to network traffic. This means the completion callback should use HTTP and port 80 instead of HTTPS and port 8888. We already had a similar conditional in the
OPI::StagerClient, this just replicates it theDiego::TaskCompletionCallbackGenerator.We didn't run CATs but we did test this manually using Eirini.
masterbranchbundle exec rake