v3(services): deleting msi synchronously#1729
Conversation
[#171726168](https://www.pivotaltracker.com/story/show/171726168) Co-authored-by: George Blue <gblue@pivotal.io> Co-authored-by: Brian Butz <bbutz@pivotal.io>
|
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/173688269 The labels on this github issue will be updated when the story is started. |
cf-gitbot
added
unscheduled
scheduled
in progress
and removed
unscheduled
scheduled
labels
| def asynchronous_destroy(service_instance) | ||
| delete_job = V3::DeleteServiceInstanceJob.new( | ||
| service_instance.guid, | ||
| :deprovision, |
There was a problem hiding this comment.
It feels a bit like we are exposing the details of the Job by providing the method we are going to send to the broker client within the action. It also feels a bit weird since the method that will be called on the client is being put into the database through the job queueing.
I think you hinted at a potential refactor across all these jobs, so it makes sense to keep this for now and maybe after the refactoring there might be an obvious way to expose this detail outside the job?
There was a problem hiding this comment.
Yeah, this is pretty much a work in progress at this point and not quite there yet. I'll keep your point in mind when consolidating the jobs 🤔
Co-authored-by: Brian Butz <butzopower@gmail.com>
3 participants
finishes #171726168