v3(services): introduce service route binding endpoint#1789
Merged
blgm merged 1 commit intocloudfoundry:masterfrom Aug 18, 2020
Merged
Conversation
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/174377750 The labels on this github issue will be updated when the story is started. |
butzopower
reviewed
Aug 18, 2020
|
|
||
| # service_route_bindings | ||
| resources :service_route_bindings, | ||
| param: :guid, |
Contributor
There was a problem hiding this comment.
This is probably fine to keep since there's likely a show or update or delete in the future, but just so you know, this is the key for the resource (opposed to resources/list) endpoints which by convention is keyed off as :id in the params.
butzopower
approved these changes
Aug 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#174063444