Merged
Conversation
todo: fake the response parser result
By concentrating the logic in the client response - it keeps it closer to the response parser that is already doing some of that translation lagic. The polling code should only care about the state field and any other raised error should be handled as fatal failure
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/175287348 The labels on this github issue will be updated when the story is started. |
…oundry/cloud_controller_ng into v3_last_operation_hanfle_refactor
blgm
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#174748988