Conversation
|
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/175388131 The labels on this github issue will be updated when the story is started. |
|
Hmm, it looks like the postgres tests are failing with errors like this: |
|
It looks like the |
njbennett
force-pushed
the
honeeycomb-pr
branch
from
6cb918a to
763e342
Compare
|
Force pushed some changes to the commit. Now we check only for the top-level honeycomb key, rather than a sub-key, because the call to get the subkey value with [] fails when the top level key returns nil. |
| use CloudFoundry::Middleware::Cors, config.get(:allowed_cors_domains) | ||
| use CloudFoundry::Middleware::VcapRequestId | ||
| use CloudFoundry::Middleware::NewRelicCustomAttributes if config.get(:newrelic_enabled) | ||
| use Honeycomb::Rack::Middleware, client: Honeycomb.client if config.get(:honeycomb, :write_key) |
There was a problem hiding this comment.
should this also be conditional on config.get(:honeycomb)?
When honeycomb.write_key is present, emit events for every incoming HTTP request, except to the /healthz endpoint Authored-by: Nat Bennett <nbennett@pivotal.io>
njbennett
force-pushed
the
honeeycomb-pr
branch
from
763e342 to
0c85f52
Compare
tcdowney
left a comment
tcdowney
left a comment
There was a problem hiding this comment.
LGTM apart from the CLA bit 🤔
|
Github not being aware that I've signed the CLA doesn't seem to stop me from merging things so 😬 |
5 participants
When
honeycomb.write_keyis present, emit events for every incomingHTTP request, except to the
/healthzendpoint.Authored-by: Nat Bennett nbennett@pivotal.io