V3 unbind service credential binding sync and async#1942
Merged
Conversation
The "require_async" flag introduced decoupling from the concepts of MSI and USPI, however we can be more intentional in using the domain and use the SI types to distinguish between the behaviours
…nd Credential binding TODO: - add audit logging for service credential binding delete - correct behaviuor on "concurrency error"
Made sure to catch concurrency errors for service bindings
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/175541441 The labels on this github issue will be updated when the story is started. |
pivotal-marcela-campo
approved these changes
Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#174187897