V3 add audit events for route bindings 175228173#1945
Merged
Conversation
- Should be usable by route bindings, credential bindings of type app and key [#175228173](https://www.pivotaltracker.com/story/show/175228173)
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/175600096 The labels on this github issue will be updated when the story is started. |
kirederik
reviewed
Nov 5, 2020
|
|
||
| def event_repository | ||
| Repositories::ServiceBindingEventRepository | ||
| Repositories::ServiceGenericBindingEventRepository.new('service_binding') |
There was a problem hiding this comment.
Should the parameter be a constant defined somewhere in the ServiceGenericBindingEventRepository? I can see a world where we decide to update it to something different and have to remember to change in multiple places 🤔
kirederik
reviewed
Nov 6, 2020
|
|
||
| def event_repository | ||
| Repositories::ServiceBindingEventRepository | ||
| Repositories::ServiceGenericBindingEventRepository.new('service_binding') |
There was a problem hiding this comment.
Everytime this method is called a new ServiceGenericBindingEventRepository will be created. It seems it's only being called once in the action, so not a big deal, but may be interesting to cache this one?
kirederik
reviewed
Nov 6, 2020
kirederik
approved these changes
Nov 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.