use TCPServer for rake-task readiness checks#1975
Merged
Conversation
- the Socket we were opening would pass the readiness probe checks initially but begin failing later - this replaces it with a TCPServer that runs in a background thread that can accept multiple readiness probe connections - addresses cloudfoundry/capi-k8s-release#91 [#175388005](https://www.pivotaltracker.com/story/show/175388005) Authored-by: Tim Downey <tdowney@vmware.com>
tcdowney
requested review from
MasslessParticle,
cwlbraa,
matt-royal and
sethboyles
cwlbraa
approved these changes
Nov 25, 2020
Contributor
cwlbraa
left a comment
cwlbraa
left a comment
There was a problem hiding this comment.
LGTM! Before we tried to unit test this, we had implemented the full server with the accepts. Did y'all ever actually see errors? What did they look like?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The socket we were opening would pass the readiness probe checks initially, but cause it to fail later with errors like:
This replaces the raw socket with a TCPServer that runs in a background thread that can accept multiple readiness probe connections.
Relates to: cloudfoundry/capi-k8s-release#91
Tracker Story: #175388005