v3(services): refactor delete for service instance#1980
Merged
Conversation
We have moved to a pattern where a controller either uses an action to do something, or schedules a job to do something, and the job uses an action under the hood. The services instances delete endpoint was using an action to schedule a job, which could be confusing as it's different to other endpoints. [#171728591](https://www.pivotaltracker.com/story/show/171728591)
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/175950481 The labels on this github issue will be updated when the story is started. |
cf-gitbot
added
in progress
delivered
accepted
and removed
scheduled
in progress
delivered
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have moved to a pattern where a controller either uses an action to
do something, or schedules a job to do something, and the job uses an
action under the hood. The services instances delete endpoint was using
an action to schedule a job, which could be confusing as it's different
to other endpoints.
#171728591