Skip to content

Fix synchronous bind is successfull#2682

Merged
philippthun merged 1 commit intocloudfoundry:mainfrom
sap-contributions:fix-synchronous-bind-is-successfull
Feb 17, 2022
Merged

Fix synchronous bind is successfull#2682
philippthun merged 1 commit intocloudfoundry:mainfrom
sap-contributions:fix-synchronous-bind-is-successfull

Conversation

@FloThinksPi
Copy link
Copy Markdown
Member

@FloThinksPi FloThinksPi commented Feb 15, 2022

In case of a synchronous bind, last_operation is nil but we should consider this a succesfull binding.

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@tjvman
Copy link
Copy Markdown
Contributor

tjvman commented Feb 15, 2022

Please fix the Rubocop errors (looks like it's just an extra blank line); we'll take a look in the meantime.

@FloThinksPi FloThinksPi force-pushed the fix-synchronous-bind-is-successfull branch from 71dff3c to a22c292 Compare February 16, 2022 07:36
@FloThinksPi
Copy link
Copy Markdown
Member Author

Hi @tjvman,
i broke the PR a bit yesterday but now its in reviewable state :).

Its a required change for both:
#2676
#2679

So i pulled it out into a separate PR

Copy link
Copy Markdown
Member

@philippthun philippthun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense. It also means that the nil checks done here and here are now superfluous; so I suggest that your remove them as part of this PR.

There is also a typo in the commit message. It should be "Treat ...".

@FloThinksPi FloThinksPi force-pushed the fix-synchronous-bind-is-successfull branch from a22c292 to aa09240 Compare February 17, 2022 15:19
@FloThinksPi
Copy link
Copy Markdown
Member Author

This change makes sense. It also means that the nil checks done here and here are now superfluous; so I suggest that your remove them as part of this PR.

There is also a typo in the commit message. It should be "Treat ...".

Have adopted that 👍🏼

@philippthun philippthun merged commit 839ddd1 into cloudfoundry:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Whats the correct way v3 broker endpoints handle operation state ?

4 participants