Fix synchronous bind is successfull#2682
Merged
philippthun merged 1 commit intocloudfoundry:mainfrom Feb 17, 2022
Merged
Conversation
fc63ab0 to
71dff3c
Compare
Contributor
|
Please fix the Rubocop errors (looks like it's just an extra blank line); we'll take a look in the meantime. |
71dff3c to
a22c292
Compare
Member
Author
This was referenced Feb 16, 2022
philippthun
reviewed
Feb 16, 2022
a22c292 to
aa09240
Compare
Member
Author
philippthun
approved these changes
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of a synchronous bind, last_operation is nil but we should consider this a succesfull binding.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests