Ensure route destinations have consistent order#2751
Closed
sethboyles wants to merge 1 commit intomainfrom
Closed
Conversation
Authored-by: Seth Boyles <sboyles@pivotal.io>
f17f3e6 to
354a398
Compare
Member
Author
|
considering PATCH destinations create multiple destinations at the same time, |
Member
If there's not a user or other component benefit to specifying an order, I'd lean toward making the tests order agnostic. Though since I haven't looked at the test code so I don't know how difficult it is to change the tests |
Member
Author
|
closing in favor of #2752 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of our route destinations assume consistent ordering from the DB, but no code actually enforces it, resulting in lots of flakes like this: https://ci.cake.capi.land/teams/main/pipelines/capi/jobs/cc-unit-tests/builds/740
This does a simple in-memory sort on the presenter.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests