Use destroy over delete for deleting unmapped routes #4100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samze
force-pushed
the
4099_fix_unmapped_route_deletion_with_labels
branch
from
ef40bbc to
2293f9d
Compare
This triggers the deletion of associated resources, like labels/annotations. Otherwise this operation gives a FK error.
Samze
force-pushed
the
4099_fix_unmapped_route_deletion_with_labels
branch
from
2293f9d to
02a2200
Compare
sethboyles
approved these changes
Nov 20, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Nov 22, 2024
Changes in cloud_controller_ng:
- Use destroy over delete for deleting unmapped routes
PR: cloudfoundry/cloud_controller_ng#4100
Author: Sam Gunaratne <385176+Samze@users.noreply.github.com>
Dependency updates in cloud_controller_ng:
- build(deps-dev): bump rubocop-sequel from 0.3.6 to 0.3.7
PR: cloudfoundry/cloud_controller_ng#4096
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This triggers the deletion of associated resources, like labels and annotations.
Otherwise this operation gives a FK error.
destroyis required to do that as part of this definition https://github.com/cloudfoundry/cloud_controller_ng/blob/main/app/models/runtime/route.rb#L46 . Since this object has already excluded any route bindings or route mappings, using destroy has no effect on mappings/bindings.Fixes #4099
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests