Skip to content

Conversation

@johha
Copy link
Contributor

@johha johha commented Jan 19, 2026

The metrics plugin is only needed for the dedicated cc workers processes.
If the execution context is not set correctly runtime errors occur.

Additionally:

  • Improve tests to avoid sporadic errors when metric is updated twice.
  • Raise an error if publish_metrics is true and execution context is not set for cc workers.
    For the local workers there is no concept yet on how to publish metrics.

Links to any other associated PRs

Issue was introduced with #4749

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

The metrics plugin is only needed for the dedicated cc workers processes.

Additionally:
- Improve tests to avoid sporadic errors when metric is updated twice.
- Raise an error if `publish_metrics` is true and execution context is not set for cc workers.
  For the local workers there is no concept yet on how to publish metrics.
@johha johha force-pushed the delayed-job-metric-plugin-loading branch from fa9fa7b to 1fc1fa0 Compare January 19, 2026 12:23
@johha johha marked this pull request as ready for review January 19, 2026 12:49
@johha johha requested review from a team January 19, 2026 12:50
@johha johha merged commit 2a41689 into main Jan 19, 2026
11 checks passed
@johha johha deleted the delayed-job-metric-plugin-loading branch January 19, 2026 13:20
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Jan 19, 2026
Changes in cloud_controller_ng:

- Load delayed job metric plugin only for cc workers
    PR: cloudfoundry/cloud_controller_ng#4783
    Author: Johannes Haass <johannes.haass@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants