Conversation
Samze
force-pushed
the
buildpack_upload_event
branch
from
8a67176 to
4531765
Compare
Samze
commented
Jan 21, 2026
| alias_method :resource_guid, :buildpack_guid | ||
|
|
||
| def initialize(buildpack_guid, buildpack_bits_path, buildpack_bits_name) | ||
| def initialize(buildpack_guid, buildpack_bits_path, buildpack_bits_name, user_audit_info=nil, request_attrs=nil) |
Contributor
Author
There was a problem hiding this comment.
note Make new parameters optional on job, incase an existing job has been serialised but yet to be processed during an upgrade.
nookala
reviewed
Jan 26, 2026
| actor_username: user_audit_info.user_name, | ||
| timestamp: Sequel::CURRENT_TIMESTAMP, | ||
| space_guid: '', | ||
| organization_guid: '', |
Contributor
There was a problem hiding this comment.
Any reason the org and space guids don't get set?
Contributor
Author
There was a problem hiding this comment.
Uploading a buildpack is not org/space scoped. It's foundation wide
sethboyles
approved these changes
Feb 2, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Feb 4, 2026
Changes in cloud_controller_ng:
- Fix issues with processes_sync:
PR: cloudfoundry/cloud_controller_ng#4809
Author: Seth Boyles <seth.boyles@broadcom.com>
- Add buildpack upload audit event
PR: cloudfoundry/cloud_controller_ng#4791
Author: Sam Gunaratne <385176+Samze@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests