Skip to content

Add admin_limit to cc.rate_limiter configuration#5149

Open
WeiQuan0605 wants to merge 3 commits into
cloudfoundry:mainfrom
sap-contributions:adapt-rate-limit-for-admin-user
Open

Add admin_limit to cc.rate_limiter configuration#5149
WeiQuan0605 wants to merge 3 commits into
cloudfoundry:mainfrom
sap-contributions:adapt-rate-limit-for-admin-user

Conversation

@WeiQuan0605
Copy link
Copy Markdown
Contributor

@WeiQuan0605 WeiQuan0605 commented Jun 5, 2026

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:
    CF API rate limits currently exclude admin users entirely. This PR extends cc.rate_limiter with an admin_limit parameter (default -1 = no limit, preserving existing behavior) that when set to a positive value applies rate limiting to admin users using their own counter, independent of the general user limit.

  • An explanation of the use cases your change solves

    • Operators want to protect the CF API from abusive or runaway automation scripts running with admin credentials
    • Without this change, admin users can send unlimited requests and potentially overwhelm the API, while regular users are protected
    • With admin_limit: -1 (default), existing deployments are unaffected
  • Links to any other associated PRs
    Capi-release Add admin_limit to cc.rate_limiter configuration capi-release#655

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant