Skip to content

Make dlinsley Credhub approver#1473

Merged
beyhan merged 1 commit into
cloudfoundry:mainfrom
Identity-and-Credentials:pr/make_daniel_credhub_approver
Apr 16, 2026
Merged

Make dlinsley Credhub approver#1473
beyhan merged 1 commit into
cloudfoundry:mainfrom
Identity-and-Credentials:pr/make_daniel_credhub_approver

Conversation

@hsinn0
Copy link
Copy Markdown
Contributor

@hsinn0 hsinn0 commented Apr 8, 2026

  • As the team currently has only two approvers, which could block PR merges if one is unavailable.

@dlinsley has been with the team for a while and has made contributions to the repos as follows for example:

https://github.com/cloudfoundry/credhub/pulls?q=is%3Apr+is%3Aclosed+author%3Adlinsley
https://github.com/cloudfoundry/credhub-cli/pulls?q=is%3Apr+is%3Aclosed+author%3Adlinsley
https://github.com/cloudfoundry/credhub-oss-ci/pulls?q=is%3Apr+is%3Aclosed+author%3Adlinsley

- As the team currently has only two approvers, which could block PR merges if one is unavailable.
@beyhan
Copy link
Copy Markdown
Member

beyhan commented Apr 9, 2026

We will require another approvals (thumps up, +1 comment,...) from the @cloudfoundry/wg-foundational-infrastructure-credential-management-credhub-approvers because we have more than four approvers in the area.

@peterhaochen47
Copy link
Copy Markdown
Member

peterhaochen47 commented Apr 9, 2026

👍 +1

@peterhaochen47
Copy link
Copy Markdown
Member

Can we merge this?

@beyhan beyhan merged commit 57523d2 into cloudfoundry:main Apr 16, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Inbox to Done in CF Community Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants