Skip to content

Prepare pipeline for consolidation#44

Merged
aramprice merged 1 commit into
developfrom
pre-consolidation-cleanup
Jul 1, 2026
Merged

Prepare pipeline for consolidation#44
aramprice merged 1 commit into
developfrom
pre-consolidation-cleanup

Conversation

@aramprice

Copy link
Copy Markdown
Member
  • bump deps now runs, lint, units, integration
  • build no longer builds darwin
  • tagging / promoting is manual (will change to final release creation)
  • remove master/develop pattern

Copilot AI review requested due to automatic review settings July 1, 2026 20:56
@aramprice aramprice force-pushed the pre-consolidation-cleanup branch from 1e6070f to a8a0bf3 Compare July 1, 2026 20:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Concourse pipeline configuration to support a consolidation workflow: rename/reshape linting, run unit + template tests, centralize integration tests after a Linux build, and simplify tagging/promotion steps (including dropping Darwin builds).

Changes:

  • Replaces the golangci-lint task entrypoint with a new ci/tasks/lint.sh wrapper that runs bin/lint.
  • Restructures ci/pipeline.yml job flow (lint → unit/templates → build (linux) → integration matrix) and adjusts tagging to be driven by version-semver.
  • Removes the Darwin build task and makes ci/configure.sh validate and (re)configure the pipeline with a login helper.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ci/tasks/lint.yml Points the lint task at the new ci/tasks/lint.sh entrypoint.
ci/tasks/lint.sh Adds a small wrapper to run the repo’s bin/lint from the correct working directory.
ci/tasks/build.yml Makes GOOS/GOARCH task params configurable (now empty) for the shared build task.
ci/tasks/build-darwin.yml Removes the Darwin-specific build task definition.
ci/pipeline.yml Renames/restructures jobs, introduces Ruby-based template tests, consolidates integration tests, and changes tagging flow.
ci/configure.sh Adds debug support, validates the pipeline, and adds a login/status loop before setting the pipeline.
Comments suppressed due to low confidence (2)

ci/tasks/build.yml:13

  • GOOS/GOARCH are left empty in the task params. If someone runs this task outside the pipeline (or forgets to pass params), build.sh will produce incorrect paths (e.g., compiled-/...) and fail in a non-obvious way. Provide defaults that match the declared output (compiled-linux), and override them from the pipeline when needed.
    ci/pipeline.yml:206
  • The ruby-image resource does not pin a tag or digest, so pipeline behavior can change unexpectedly when Docker Hub updates ruby:latest. Pinning to a specific version (or digest) improves reproducibility and reduces surprise breakages.
  - name: ruby-image
    type: registry-image
    source:
      repository: ruby
      username: ((dockerhub_username))
      password: ((dockerhub_password))

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ci/pipeline.yml
Comment thread ci/configure.sh
@aramprice aramprice force-pushed the pre-consolidation-cleanup branch 4 times, most recently from 881785c to 028af74 Compare July 1, 2026 21:09
- bump deps now runs, lint, units, integration
- build no longer builds darwin
- remove tagging, semver resource
- remove master/develop pattern
- remove protect-master workflow
- add placeholder for release creation
@aramprice aramprice force-pushed the pre-consolidation-cleanup branch from 028af74 to ddee5d8 Compare July 1, 2026 21:16
@aramprice aramprice merged commit c772105 into develop Jul 1, 2026
5 checks passed
@aramprice aramprice deleted the pre-consolidation-cleanup branch July 1, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants