Prepare pipeline for consolidation#44
Merged
Merged
Conversation
aramprice
commented
Jul 1, 2026
Member
- bump deps now runs, lint, units, integration
- build no longer builds darwin
- tagging / promoting is manual (will change to final release creation)
- remove master/develop pattern
1e6070f to
a8a0bf3
Compare
There was a problem hiding this comment.
Pull request overview
Updates the Concourse pipeline configuration to support a consolidation workflow: rename/reshape linting, run unit + template tests, centralize integration tests after a Linux build, and simplify tagging/promotion steps (including dropping Darwin builds).
Changes:
- Replaces the golangci-lint task entrypoint with a new
ci/tasks/lint.shwrapper that runsbin/lint. - Restructures
ci/pipeline.ymljob flow (lint → unit/templates → build (linux) → integration matrix) and adjusts tagging to be driven byversion-semver. - Removes the Darwin build task and makes
ci/configure.shvalidate and (re)configure the pipeline with a login helper.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ci/tasks/lint.yml | Points the lint task at the new ci/tasks/lint.sh entrypoint. |
| ci/tasks/lint.sh | Adds a small wrapper to run the repo’s bin/lint from the correct working directory. |
| ci/tasks/build.yml | Makes GOOS/GOARCH task params configurable (now empty) for the shared build task. |
| ci/tasks/build-darwin.yml | Removes the Darwin-specific build task definition. |
| ci/pipeline.yml | Renames/restructures jobs, introduces Ruby-based template tests, consolidates integration tests, and changes tagging flow. |
| ci/configure.sh | Adds debug support, validates the pipeline, and adds a login/status loop before setting the pipeline. |
Comments suppressed due to low confidence (2)
ci/tasks/build.yml:13
- GOOS/GOARCH are left empty in the task params. If someone runs this task outside the pipeline (or forgets to pass params), build.sh will produce incorrect paths (e.g., compiled-/...) and fail in a non-obvious way. Provide defaults that match the declared output (compiled-linux), and override them from the pipeline when needed.
ci/pipeline.yml:206 - The ruby-image resource does not pin a tag or digest, so pipeline behavior can change unexpectedly when Docker Hub updates
ruby:latest. Pinning to a specific version (or digest) improves reproducibility and reduces surprise breakages.
- name: ruby-image
type: registry-image
source:
repository: ruby
username: ((dockerhub_username))
password: ((dockerhub_password))
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
881785c to
028af74
Compare
- bump deps now runs, lint, units, integration - build no longer builds darwin - remove tagging, semver resource - remove master/develop pattern - remove protect-master workflow - add placeholder for release creation
028af74 to
ddee5d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.