Skip to content

Migrate from unmaintained gopkg.in/yaml.v3 to go.yaml.in/yaml/v3#132

Merged
peterhaochen47 merged 2 commits intomainfrom
migrate-yaml
Feb 6, 2026
Merged

Migrate from unmaintained gopkg.in/yaml.v3 to go.yaml.in/yaml/v3#132
peterhaochen47 merged 2 commits intomainfrom
migrate-yaml

Conversation

@hsinn0
Copy link
Copy Markdown
Contributor

@hsinn0 hsinn0 commented Feb 5, 2026

To replace #131 with conflict resolution.

Signed-off-by: Taylor Silva <dev@taydev.net>
@hsinn0
Copy link
Copy Markdown
Contributor Author

hsinn0 commented Feb 5, 2026

BTW, I did make build test to make sure it is all good.

@peterhaochen47
Copy link
Copy Markdown
Member

peterhaochen47 commented Feb 5, 2026

AI code review. Seems valid. The "unmaintained gopkg.in/yaml.v3" is still being used.

Issues found
Incomplete migration: credhub/credentials/types_test.go still imports gopkg.in/yaml.v3. This should be updated to go.yaml.in/yaml/v3 to complete the migration.
Dependency status: go.mod still lists both libraries:
go.yaml.in/yaml/v3 v3.0.4 (direct)
gopkg.in/yaml.v3 v3.0.1 (direct)
After migrating the test file, gopkg.in/yaml.v3 can be removed from go.mod if it's no longer used.
...
After this change:
Run go mod tidy again to remove gopkg.in/yaml.v3 if it's no longer needed

- Removed the remaining use of the package.
@hsinn0
Copy link
Copy Markdown
Contributor Author

hsinn0 commented Feb 5, 2026

Removed the remaining use of the package in the new commit.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Feb 6, 2026
@peterhaochen47 peterhaochen47 merged commit c92cc3c into main Feb 6, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants