Merged
Conversation
See grpc/grpc-go#3669 for more info.
Bad idea to directly compare protobuf messages because the sizeCache differs. Instead use `proto.Equal()` where appropriate. Since the two things we care about are EventType (integer) and HttpStartStop (protobuf message), we can compare one directly and the other with `proto.Equal()`.
Dereferencing envelopes[0] into `Expect()` meant we were copying the lock value of a mutex contained in the envelope.
* Using the protobuf definitions at cloudfoundry/loggregator-api#23. * This changes the source to avoid namespace conflicts and uses a newer version of protoc. * Update generate script accordingly. Signed-off-by: Ben Fuller <benjaminf@vmware.com>
Signed-off-by: Carson Long <lcarson@vmware.com>
Signed-off-by: Ben Fuller <benjaminf@vmware.com>
Signed-off-by: Carson Long <lcarson@vmware.com>
* Removes many transitive dependencies Signed-off-by: Carson Long <lcarson@vmware.com>
Benjamintf1
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eventssonde-go#9google.golang.org/protobufResolves #62