This repository was archived by the owner on Apr 30, 2025. It is now read-only.
Route service pruning fix #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 042e2db.
Pruning endpoints when route-services fail has a few unfortunate side-effects: - there are load-balancing issues during the time of a pruned route which result in not all active apps receiving their share of traffic (cloudfoundry/routing-release#262) - apps relying on sticky-sessions + route-services that return 401/403s to clients as part of an auth flow end up breaking the sticky session This reverts commit 039ab0c.
This provides a solution to issues where stale routes containing out of date/failing route-service information are never detected, and ended up causing errors for all app instances, when the stale route was at index 0 of an endpoint pool. This was previously fixed with #298, but that caused issues with loadbalancing fairness, and sticky sessions. Instead of pruning the endpoint with the failing route-service, to force it to be re-registered with an up-to-date route-service, gorouter now treats the route-service as an endpoint-pool property, and updates the route-service whenever a new registration occurs. Also adds integration tests to ensure we didn't regress on the behavior resolved in #298. Signed-off-by: Amelia Downs <adowns@vmware.com>
mariash
approved these changes
Apr 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a solution to issues where stale routes containing out of date/failing route-service
information are never detected, and ended up causing errors for all app
instances, when the stale route was at index 0 of an endpoint pool.
This was previously fixed with #298, but
that caused issues with loadbalancing fairness, and sticky sessions.
Instead of pruning the endpoint with the failing route-service, to force
it to be re-registered with an up-to-date route-service, gorouter now
treats the route-service as an endpoint-pool property, and updates the
route-service whenever a new registration occurs.