This repository was archived by the owner on Apr 30, 2025. It is now read-only.
Fix nil panic #372
Merged
Fix nil panic #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmoehl
force-pushed
the
fix-nil-panic
branch
from
95ba1c9 to
b41e359
Compare
Member
Author
|
I'll try to come up with a regression test for this. |
domdom82
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change: Only call close on the original requests body if it is non-nil, otherwise this will cause a panic.
An explanation of the use cases your change solves: Prevent panics.
Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics)
Expected result after the change: No panic if we have a client request without a body and the client disconnects early.
Current result before the change: gorouter panics if we have a client request without a body and the client disconnects early.
Links to any other associated PRs: Fix memory leak when connections are prematurely closed on the client… #333
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests.
(Optional) I have run Routing Acceptance Tests and Routing Smoke Tests
(Optional) I have run CF Acceptance Tests