This repository was archived by the owner on Apr 30, 2025. It is now read-only.
add availability zone to endpoints #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* get it to show up in /routes endpoint * remove easyjson. it has not been released since 2021 and has had no commits in 19 months.
ameowlia
force-pushed
the
add-az-to-endpoint
branch
from
62bea21 to
c0d2fdb
Compare
jrussett
approved these changes
Dec 15, 2023
Contributor
jrussett
left a comment
jrussett
left a comment
There was a problem hiding this comment.
Changes look good to me 👍
I was able to observe the new field in the route:
router/0055525f-d27a-4ca7-870f-8b1e20ed6c6b:~# /var/vcap/jobs/gorouter/bin/retrieve-local-routes | jq -r '.["rutabaga.opus-404117.cf-app.com"]'
[
{
"address": "10.0.1.13:61002",
"availability_zone": "z1", 👈 New Field hooray! 🎉
"protocol": "http1",
"tls": true,
"ttl": 120,
"tags": {
"app_id": "f3567c2d-0d82-4e3c-9b9e-c1254ef47303",
"app_name": "rutabaga",
"component": "route-emitter",
"instance_id": "0",
"organization_id": "7b8595d6-6f8b-4be5-97d5-be7f5aa202bc",
"organization_name": "system",
"process_id": "f3567c2d-0d82-4e3c-9b9e-c1254ef47303",
"process_instance_id": "db2c1075-a05d-4c78-40c8-ab5f",
"process_type": "web",
"source_id": "f3567c2d-0d82-4e3c-9b9e-c1254ef47303",
"space_id": "208286e3-0adf-4851-95f7-3a4162ee6738",
"space_name": "system"
},
"private_instance_id": "db2c1075-a05d-4c78-40c8-ab5f",
"server_cert_domain_san": "db2c1075-a05d-4c78-40c8-ab5f"
}
]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Add availability zones to endpoints as as step towards az-aware routing. Also, remove easyjson which hasn't been released since 2021, and hasn't been committed to for the past 19 months.
Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics)
/var/vcap/jobs/gorouter/bin/retrieve-local-routes | jq .and find your route.Expected result after the change
It will have the availability zone of the endpoint listed.
Current result before the change
No availability zone information is provided.
Links to any other associated PRs
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests.
(Optional) I have run Routing Acceptance Tests and Routing Smoke Tests
(Optional) I have run CF Acceptance Tests