Read trusted_domain_cidrs from a file#135
Merged
geofffranks merged 1 commit intocloudfoundry:masterfrom May 7, 2019
Merged
Conversation
|
✅ Hey Soha-Albaghdady! The commit authors and yourself have already signed the CLA. |
When the trusted_domain_cidrs list was too long haproxy start-up failed with the following error: parsing [/var/vcap/jobs/haproxy/config/haproxy.config:60]: line too long, truncating at word 65, position 1049 Additionally trusted_domain_cidrs can be provided as a base64 encoded string.
Soha-Albaghdady
force-pushed
the
file_trusted_domain
branch
from
125e5c1 to
37a4301
Compare
Contributor
|
Thanks for the fix! One question though - what was the driver for adding the base64 support? |
Contributor
Author
|
Thanks for the review! It only to have a shorter manifest, and also to be consistent with the |
Contributor
Author
|
@geofffranks thanks for merging! when is the next release planned? |
Contributor
|
Should be this morning, just need to update release notes and wait on the pipelines
…Sent from my iPhone
On May 8, 2019, at 3:36 AM, Soha-Albaghdady ***@***.***> wrote:
@geofffranks thanks for merging! when is the next release planned?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
|
released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the trusted_domain_cidrs list was too long haproxy start-up failed
with the following error:
parsing [/var/vcap/jobs/haproxy/config/haproxy.config:60]: line too long,
truncating at word 65, position 1049
Additionally trusted_domain_cidrs can be provided as a base64 encoded
string.