new raw blocks: listen, frontend, backend#652
Merged
maxmoehl merged 3 commits intocloudfoundry:masterfrom Apr 26, 2024
kinjelom:master
Merged
new raw blocks: listen, frontend, backend#652maxmoehl merged 3 commits intocloudfoundry:masterfrom kinjelom:master
maxmoehl merged 3 commits intocloudfoundry:masterfrom
kinjelom:master
Conversation
maxmoehl
previously requested changes
Apr 17, 2024
Member
maxmoehl
left a comment
maxmoehl
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Can you please add some tests? Then we can run it through our CI to see if everything works as expected.
Member
|
And please drop the merge commit, we prefer a linear history :) |
Contributor
Author
I've added some tests. @maxmoehl Could you please check my code? PS. I'm already using this in my dev https://github.com/kinjelom/haproxy-boshrelease/releases/tag/v13.3.1%2B2.8.9 |
Closed
b1tamara
previously approved these changes
Apr 26, 2024
Contributor
b1tamara
left a comment
b1tamara
left a comment
There was a problem hiding this comment.
LGTM
Unit-tests and acceptance-test are green
Member
|
I went ahead and cleaned up the history. @b1tamara please approve again, I'll enable auto-merge to get it in. |
Contributor
Author
|
thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proper formatting of indented multiline configurations, new raw blocks: listen, frontend, backend.