fix(disable_tcp_accept_proxy): honor flag with non-SSL TCP backends#684
Merged
fix(disable_tcp_accept_proxy): honor flag with non-SSL TCP backends#684
Conversation
maxmoehl
previously approved these changes
Jun 24, 2024
peanball
force-pushed
the
tcp-proxy-protocol-non-tls
branch
from
8f9df40 to
6cc464e
Compare
Soha-Albaghdady
approved these changes
Jun 24, 2024
ameowlia
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
accept_proxyis set, theaccept-proxysetting is set on all backends.TCP backends can opt out by using the flag
disable_tcp_accept_proxy, which defaults tofalse. This means without configuring explicitly, TCP backends should also have theaccept-proxydeclaration.The
haproxy.config.erbfile did not include the correct value foraccept-proxyon non-SSL backends. It now does. The spec test was only checking SSL backends so far. Now it's checking a mix.