Memory settings are ignored in latest buildpack

[garethjevans]

Hi,

Using https://github.com/cloudfoundry/java-buildpack#c4c0af7, our attempts to reconfigure the memory settings appear to be ignored.

cf env app | grep JBP
JBP_CONFIG_OPEN_JDK_JRE: [version: 1.8.0_+, memory_heuristics: {heap: 65, stack: 5, metaspace: 10, native: 20}]

but, when the app is restaged, we can see that these values are not used.

-----> Downloaded app package (56M)
-----> Downloaded app buildpack cache (50M)
Cloning into '/tmp/buildpacks/java-buildpack'...
[ConfigurationUtils]             WARN  User config value for 'version' is not valid, existing property not present
[ConfigurationUtils]             WARN  User config value for 'memory_heuristics' is not valid, existing property not present
-----> Java Buildpack Version: c4c0af7 | https://github.com/cloudfoundry/java-buildpack#c4c0af7
-----> Downloading Open Jdk JRE 1.8.0_45 from https://download.run.pivotal.io/openjdk/lucid/x86_64/openjdk-1.8.0_45.tar.gz (found in cache)
       Expanding Open Jdk JRE to .java-buildpack/open_jdk_jre (1.1s)
-----> Downloading Open JDK Like Memory Calculator 1.1.1_RELEASE from https://download.run.pivotal.io/memory-calculator/lucid/x86_64/memory-calculator-1.1.1_RELEASE (found in cache)
       Memory Settings: -XX:MaxMetaspaceSize=78643K -XX:MetaspaceSize=78643K -Xss1M -Xmx576M -Xms576M
-----> Downloading New Relic Agent 3.16.1 from https://download.run.pivotal.io/new-relic/new-relic-3.16.1.jar (found in cache)
[ConfigurationUtils]             WARN  User config value for 'version' is not valid, existing property not present
[ConfigurationUtils]             WARN  User config value for 'memory_heuristics' is not valid, existing property not present
-----> Uploading droplet (106M)

What is the correct syntax for configuring these?

Thanks,

Gareth

[garethjevans]

It seems to be caused by 9393dc1.

The latest format for the buildpack appears to have changed to:

JBP_CONFIG_OPEN_JDK_JRE '[jre: {version: 1.8.0_+}, memory_calculator: {memory_heuristics: {heap: 65, stack: 5, metaspace: 10, native: 20}}]'

This sets the correct values for calculating the memory sizes

 -memoryWeights=heap:65,metaspace:10,stack:5,native:20

Should probably update the doc on the main page.

Gareth

[garethjevans]

Created pull request #192

[cgfrost]

Hi,

Thanks for the updates, that's awesome.

[cgfrost]

I'm closing this issue out, pull request #192 has been merged. The change will be in the next release of the buildpack. Thanks for the contribution.