Tomcat Redis Session Replication#104
Closed
cgfrost wants to merge 1 commit intocloudfoundry:masterfrom
cgfrost:80362118-session-replication
Closed
Tomcat Redis Session Replication#104cgfrost wants to merge 1 commit intocloudfoundry:masterfrom cgfrost:80362118-session-replication
cgfrost wants to merge 1 commit intocloudfoundry:masterfrom
cgfrost:80362118-session-replication
Conversation
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/80663976. |
Contributor
|
@cgfrost Can you please add a test that demonstrates the changed behavior? |
When the Tomcat Redis sub-component detects a service with a name, label, or tag that has `session-replication` as a substring but both 'host' and 'hostname' as credentials it will fail to use the service. This commit changes the service detection logic to require at least one credential from a group instead of exactly one credential from a group. It is up to the individual containers to handle the credentials provided. In the case of the Tomcat Redis sub-component 'hostname' will win but this is not documented and users should not rely on that behaviour in the instances where both 'host' and 'hostname' are provided with different values. [#80362118]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Tomcat Redis sub-component detects a service with a name, label, or
tag that has
session-replicationas a substring but both 'host' and'hostname' as credentials it will fail to use the service. This commit changes
the service detection logic to require at least one credential from a group
instead of exactly one credential from a group. It is up to the individual
containers to handle the credentials provided. In the case of the Tomcat Redis
sub-component 'hostname' will win but this is not documented and users should
not rely on that behaviour in the instances where both 'host' and 'hostname'
are provided with different values.
[#80362118]