[go-migration] Correct framework order for java_cf_env and spring auto reconfiguration#1157
Merged
ramonskie merged 4 commits intocloudfoundry:feature/go-migrationfrom Jan 29, 2026
Merged
Conversation
kiril-keranov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpringAutoReconfigurationFrameworkshould not be enabled ifJavaCfEnvFrameworkis already enabled. Spring Auto Reconfiguration is only provided if Java Cf Env is explicitly disabled. Currently if an app is staged like:both will be provided because this check won't pass since the Java Cf Env is detected later in the sequence.
Note: Java Cf Env is enabled by default, without explicitly setting it like in the example above, so if staged like below it will reproduce also:
Some tests integration tests with regard to those frameworks are also adjusted. Another test that always passed and tested nothing was removed.