Fix issues in play, spring-boot-cli containers and add tests#1250
Merged
ramonskie merged 11 commits intocloudfoundry:mainfrom Apr 23, 2026
Merged
Fix issues in play, spring-boot-cli containers and add tests#1250ramonskie merged 11 commits intocloudfoundry:mainfrom
ramonskie merged 11 commits intocloudfoundry:mainfrom
Conversation
Contributor
kiril-keranov
commented
Apr 22, 2026
kiril-keranov
commented
- Fix issues in play framework container detection logic. Refactor and remove duplications
- Fix issues in spring-boot-cli additional classpath amendment logic
- Add/Amend unit tests where missing for certain frameworks and remove existing dummy tests that not tested anything
ramonskie
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.