Skip to content

Changes required for Spring Insight on PCF 1.5.x#222

Closed
dtillman wants to merge 2 commits intocloudfoundry:masterfrom
dtillman:master
Closed

Changes required for Spring Insight on PCF 1.5.x#222
dtillman wants to merge 2 commits intocloudfoundry:masterfrom
dtillman:master

Conversation

@dtillman
Copy link
Copy Markdown

This commit makes a number of changes which are required for
compatibility with Spring Insight on PCF 1.5.x.

This commit makes a number of changes which are required for
compatibility with Spring Insight on PCF 1.5.x.
@cfdreddbot
Copy link
Copy Markdown

Hey dtillman!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cgfrost
Copy link
Copy Markdown
Contributor

cgfrost commented Aug 28, 2015

Hi Dave, this looks good to me but could you update the pull request to remove the commented out code. If it's not needed I'd rather not have it there at all.

Thanks, Chris.

@dtillman
Copy link
Copy Markdown
Author

Hi Chris,
I've removed the commented out old code!
Dave

@cgfrost
Copy link
Copy Markdown
Contributor

cgfrost commented Aug 28, 2015

Looks good, I think @nebhale want to have a chat with you before I merge it in though. I'm sure he will get in touch soon.

@cgfrost
Copy link
Copy Markdown
Contributor

cgfrost commented Sep 3, 2015

Hi Dave, I'm waiting to get the OK to merge this in but I'd like to keep it as ready as possible in the mean time. We're about to do a release and I want to avoid hold ups when it comes time to do it. So, with that in mind could you re-base on top of master and squash the pull request in to a single commit. While you are at it could you check the indentation hasn't changed. Rubocop will pull you up on it if it has during a bundle exec rake run. I've commented the code where it looks like it might of changed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation.

@cgfrost
Copy link
Copy Markdown
Contributor

cgfrost commented Sep 9, 2015

@dtillman Hi Dave, I'm OK now to merge this in and get it released once you have done the changes. Thanks, Chris.

@cgfrost cgfrost closed this in 3b68024 Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants