Override App Dynamics tierName from credentials#81
Closed
cgfrost wants to merge 1 commit intocloudfoundry:masterfrom
cgfrost:75252498
Closed
Override App Dynamics tierName from credentials#81cgfrost wants to merge 1 commit intocloudfoundry:masterfrom cgfrost:75252498
cgfrost wants to merge 1 commit intocloudfoundry:masterfrom
cgfrost:75252498
Conversation
|
Hey cgfrost! Thanks for submitting this pull request! All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. |
The tierName provided to App Dynamics is hard coded in the config yml file and it is beter to support an optional override with a new property in the credentials of the bound App Dynamics service. This commit changes the configuration property to 'default_tire_name' and allows it to be over-ridded with a 'tier_name' property in the App Dynamics service credentials. See: #55 See: #59 [#75252498]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tierName provided to App Dynamics is hard coded in the config yml file and
it is beter to support an optional override with a new property in the
credentials of the bound App Dynamics service. This commit changes the
configuration property to 'default_tire_name' and allows it to be over-ridded
with a 'tier_name' property in the App Dynamics service credentials.
See: #55
See: #59
[#75252498]