Truncate counter metric with fractional part instead of dropping it#718
Merged
Conversation
We observed otelcol_process_cpu_seconds_total was available intermittently. This is a counter metric, but most time, its value has fractional part, thus dropped by prom-scraper. The solution is to truncate it to uint64 instead of dropping it.
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
jorbaum
approved these changes
Mar 27, 2026
| } | ||
|
|
||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| defer func() { |
Contributor
There was a problem hiding this comment.
Looks good. I think this is probably the cleaner solution compared to mine (see 8f021ec ).
mkocher
approved these changes
Apr 1, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We observed otelcol_process_cpu_seconds_total was available intermittently. This is a counter metric, but most time, its value has fractional part, thus dropped by prom-scraper. The solution is to truncate it to uint64 instead of dropping it.
Description
We observed otelcol_process_cpu_seconds_total was available intermittently. This is a counter metric, but most time, its value has fractional part, thus dropped by prom-scraper. The solution is to truncate it to uint64 instead of dropping it. And lint fix.
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack