Aws sdk migration#1845
Conversation
IvanBorislavovDimitrov
force-pushed
the
aws-sdk-migration
branch
10 times, most recently
from
0293125 to
616a49d
Compare
LMCROSSITXSADEPLOY-3315
Previously testConnection probed for a non-existent test object on the underlying store, which produced misleading results when the bucket or container itself was missing. The check now explicitly verifies that the target bucket/container exists and throws IllegalStateException with a clear OBJECT_STORE_BUCKET_NOT_FOUND message when it does not, making configuration errors fail fast with an actionable diagnostic. LMCROSSITXSADEPLOY-3315
IvanBorislavovDimitrov
force-pushed
the
aws-sdk-migration
branch
from
616a49d to
2a642fa
Compare
|
|
| Stage | Result | Notes |
|---|---|---|
Deploy (deploy-service-pusher-oq) |
PASS | — |
Tests (qa-tester, targeted) |
PASS | Single scenario: failed-async-service-instance-operations-scenario. No failures. |
Log analysis (log-analyzer) |
PASS | 0 regression suspects in the post-deploy window. |
Verdict rationale
All three upstream stages report PASS. Deploy succeeded, the single targeted scenario (failed-async-service-instance-operations-scenario) ran clean with zero failed jobs, and the log analyzer classified all 933 WARN/ERROR hits in the 6-minute window as either expected (7) or known infrastructure noise (926: missing audit-log/ANS bindings, namespace warnings, expected Flowable dead-letter from the deliberately-failing async-service step). No suspects flagged as regression-related, no version skew between multiapps / multiapps-controller / xsa-multiapps-controller. Coverage caveat: this PR migrates the object-store persistence layer to AWS SDK v2 and refactors the upload orchestrator, and none of those code paths were exercised by the targeted scenario — please run a full OQ wave to validate the file-upload / object-store changes before merging.
PR change surface
- Files changed: 29 (
+1723/-382) - Modules touched:
multiapps-controller-api,multiapps-controller-persistence(object-store storage backends: newAwsS3ObjectStoreFileStorage, refactoredGcp/JClouds/Azurestorage +testConnectionsemantics),multiapps-controller-process(test only),multiapps-controller-web(ObjectStoreFileStorageFactoryBean,ObjectStoreServiceInfoCreator,AsyncUploadJobOrchestrator, newFileUploadResilientOperationExecutor), and rootpom.xml. - Suspect overlap: none — log analyzer produced 0 regression suspects, so there is no overlap to report.
- Coverage gap: the targeted scenario exercises broker-failure paths under
async-services; it does not touch the object-store upload paths changed by this PR. Treat the clean log signal as confirmation that the broker-failure path was unaffected, not as full validation of the AWS SDK migration.
Log analysis summary
- Expected (test-driven): 7
- Infrastructure / transient: 926
- Potentially regression-related: 0
- Likely caused by PR: 0
- Unlikely caused by PR: 0
- Inconclusive: 0
- Version skew: none
Full log-analyzer findings
Log Analyzer — oq verdict: PASS
Preflights:
- Window-anchor check:
window_start(10:13:10Z) >deploy_start(10:11:13Z), delta ~2 min — valid DEPLOY_END anchor. - CF identity gate: user/org/space match OQ requirements exactly.
- OQ reference catalog: FRESH (no rebuild needed).
- Note: This was a TARGETED run — only
failed-async-service-instance-operations-scenariowas executed. Coverage is narrower than a full OQ wave.
Deploy chain version pinning
| Source of truth | Truth value | Declared in downstream | Declared value | Status |
|---|---|---|---|---|
multiapps/pom.xml <version> |
2.49.0-SNAPSHOT |
multiapps-controller <multiapps.version> (uncommitted) |
2.49.0-SNAPSHOT |
OK (uncommitted) |
multiapps/pom.xml <version> |
2.49.0-SNAPSHOT |
xsa-multiapps-controller <multiapps.version> (uncommitted) |
2.49.0-SNAPSHOT |
OK (uncommitted) |
multiapps-controller/pom.xml <version> |
2.48.0-SNAPSHOT |
xsa-multiapps-controller <multiapps-controller.version> |
2.48.0-SNAPSHOT |
OK |
Version pinning is consistent. No skew.
Categorization
| Category | Count |
|---|---|
| Expected (test-driven) | 7 |
| Infrastructure / transient | 926 |
| Potentially regression-related (Bucket C) | 0 |
Total WARN+ERROR in window: 933
Bucket A — Expected (7 hits)
Matched via global signatures (2: broker_failure / broker returned) and scenario signatures (5: generic-content-deploy / content_error / Exception caught).
The targeted scenario failed-async-service-instance-operations-scenario is mapped under async-services (both configure-custom-service-broker and failed-creation steps) but the catalog has no expected signatures defined yet for those steps — so its log lines fall through to indeterminate. Catalog coverage gap, not a regression signal.
Bucket B — Infrastructure / transient (926 hits, 0 regression markers)
| Signature | Count | Assessment |
|---|---|---|
Failed to write message to the audit log |
787 | OQ space has no SAP audit-log service bound. Not in PR diff. |
Ignoring parameter "namespace"... |
76 | Scenario MTA has no namespace. Not in PR diff. |
Notification for Unknown NOT sent to ANS... |
29 | No ANS binding. Not in PR diff. |
Skipping deletion of services... |
6 | Informational. |
Error while closing command context |
5 | Benign teardown. |
Dead letter job detected for process ... |
4 | Expected from failed-creation. |
Job execution failure detected ... |
4 | Same Flowable failure path. |
Could not bind optional service "test-resource"... |
1 | Optional-service binding failure, normal. |
Services will be bound/unbound sequentially... |
1 | Informational. |
Job ... failed |
1 | Same Flowable failure path. |
None of these signatures intersect a class, package, or method touched by the PR diff.
Bucket C — Potentially regression-related
0 suspects. The triage engine found zero entries with verdict unexpected and zero indeterminate entries with regression markers.
Verdict rationale
The triage engine classified all 933 WARN/ERROR hits as either expected (7) or indeterminate-without-regression-marker (926). Zero hits flagged as unexpected or carried regression markers (NPE, OOM, deadlock, pool exhaustion, etc.). Every top-N indeterminate signature is a well-understood background noise source in the OQ space, and none of those source classes appear in the PR's changed-file set.
The PR diff is entirely scoped to the object-store persistence layer (new AwsS3ObjectStoreFileStorage, refactored testConnection() in GcpObjectStoreFileStorage / JCloudsObjectStoreFileStorage, ObjectStoreFileStorageFactoryBean / ObjectStoreServiceInfoCreator updates, and an AsyncUploadJobOrchestrator refactor with a new FileUploadResilientOperationExecutor). The targeted OQ scenario exercises service-broker failure paths, not the file-upload/object-store path.
Coverage note: because only one scenario was run, the object-store upload paths changed by the PR were not exercised in this OQ wave. The absence of regressions in this window is meaningful but limited — it confirms the service-broker failure path was unaffected; it does not validate the full AWS SDK migration or the new testConnection semantics under load.
Overall verdict: PASS
Failed scenarios
OQ_FAILED_JOBS: [] — none.
Posted by pr-result-publisher. Mode: oq (targeted). Generated 2026-05-29T10:20:00Z.
1 participant
No description provided.