Skip to content

Fix bufio.Scanner: token too long error#96

Merged
dgodd merged 2 commits intocloudfoundry:developfrom
mainephd:master
Jul 21, 2017
Merged

Fix bufio.Scanner: token too long error#96
dgodd merged 2 commits intocloudfoundry:developfrom
mainephd:master

Conversation

@mainephd
Copy link
Copy Markdown

@mainephd mainephd commented Jul 20, 2017

Thanks for contributing to the buildpack. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:
    Convert the fileHasString function to use bufio.Reader instead of bufio.Scanner

  • An explanation of the use cases your change solves
    When deploying an application the uses the ibm_db node_module an end user will get this error when when using npm as the package manager. It apears to happen because the verbose logging that occurs when this particular module is installed. This behavior does not occur when using yarn.

---snippped---
99.64% | 18636800 bytes downloaded out of 18703240 bytes.
99.69% | 18644992 bytes downloaded out of 18703240 bytes.
99.73% | 18653184 bytes downloaded out of 18703240 bytes.
99.78% | 18661376 bytes downloaded out of 18703240 bytes.
99.82% | 18669568 bytes downloaded out of 18703240 bytes.
99.86% | 18677760 bytes downloaded out of 18703240 bytes.
99.91% | 18685952 bytes downloaded out of 18703240 bytes.
100.00% | 18702336 bytes downloaded out of 18703240 bytes.
99.95% | 18694144 bytes downloaded out of 18703240 bytes.
100.00% | 18703240 bytes downloaded out of 18703240 bytes.
****************************************
You are downloading a package which includes the Node.js module for IBM DB2/Informix.  The module is licensed under the Apache License 2.0. The package also includes IBM ODBC and CLI Driver
 from IBM, which is automatically downloaded as the node module is installed on your system/device. The license agreement to the IBM ODBC and CLI Driver is available in /tmp/app/node_module
s/ibm_db/installer   Check for additional dependencies, which may come with their own license agreement(s). Your use of the components of the package and dependencies constitutes your accep
tance of their respective license agreements. If you do not accept the terms of any license agreement(s), then delete the relevant component(s) from your device.

****************************************
Downloading and extraction of DB2 ODBC CLI Driver completed successfully ...
make: Entering directory `/tmp/app/node_modules/ibm_db/build'
  CXX(target) Release/obj.target/odbc_bindings/src/odbc.o
  CXX(target) Release/obj.target/odbc_bindings/src/odbc_connection.o
  CXX(target) Release/obj.target/odbc_bindings/src/odbc_statement.o
  CXX(target) Release/obj.target/odbc_bindings/src/odbc_result.o
  SOLINK_MODULE(target) Release/obj.target/odbc_bindings.node
  COPY Release/odbc_bindings.node
make: Leaving directory `/tmp/app/node_modules/ibm_db/build'
added 138 packages in 75.975s
-----> Caching build
       Clearing previous node cache
       Saving 3 cacheDirectories (default):
       - .npm
       - .cache/yarn
       - bower_components (nothing to cache)
       **ERROR** bufio.Scanner: token too long
Failed to compile droplet
Exit status 223
Staging failed: Exited with status 223
Destroying container
Successfully destroyed container
  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have added an integration test

@cfdreddbot
Copy link
Copy Markdown

Hey mainephd!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

@cf-gitbot
Copy link
Copy Markdown

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/149238227

The labels on this github issue will be updated when the story is started.

@sclevine
Copy link
Copy Markdown
Contributor

@mainephd Thanks for the report!

Are you able to sign the CLA, or should we fix this separately?

@mainephd
Copy link
Copy Markdown
Author

mainephd commented Jul 20, 2017

i can sign the CLA. @sclevine You should see the signed CLA shortly.

@mainephd
Copy link
Copy Markdown
Author

@sclevine I submitted the signed CLA and i got confirmation that it was received via email.

@sclevine sclevine closed this Jul 21, 2017
@sclevine sclevine reopened this Jul 21, 2017
@cfdreddbot
Copy link
Copy Markdown

Hey mainephd!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link
Copy Markdown

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/149316041

The labels on this github issue will be updated when the story is started.

@sclevine
Copy link
Copy Markdown
Contributor

Thanks @mainephd! Prioritized to be merged.

@dgodd dgodd merged commit 19fefaf into cloudfoundry:develop Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants