Fix bufio.Scanner: token too long error#96
Conversation
|
Hey mainephd! Thanks for submitting this pull request! All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/149238227 The labels on this github issue will be updated when the story is started. |
|
@mainephd Thanks for the report! Are you able to sign the CLA, or should we fix this separately? |
|
i can sign the CLA. @sclevine You should see the signed CLA shortly. |
|
@sclevine I submitted the signed CLA and i got confirmation that it was received via email. |
|
Hey mainephd! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/149316041 The labels on this github issue will be updated when the story is started. |
|
Thanks @mainephd! Prioritized to be merged. |
Thanks for contributing to the buildpack. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Convert the
fileHasStringfunction to usebufio.Readerinstead ofbufio.ScannerAn explanation of the use cases your change solves
When deploying an application the uses the
ibm_dbnode_module an end user will get this error when when using npm as the package manager. It apears to happen because the verbose logging that occurs when this particular module is installed. This behavior does not occur when usingyarn.I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have added an integration test