Remove cf-helper-php from test fixtures to fix Composer 2.9.8 failures#1273
Merged
Merged
Conversation
Composer 2.9.8 blocks packages with known security advisories by default. The cf-helper-php 1.6.x dependency pulls in filp/whoops ~1.1 and symfony/yaml ~2.5, both flagged with advisories, causing staging failures in the phpredis and amqp module tests. Remove cf-helper-php from both fixtures since the tests only verify that PHP extensions (ext-redis, ext-amqp) load correctly. Simplify the phpredis index.php to connect directly to localhost instead of using CfHelper to parse VCAP_SERVICES (no Redis service is bound in tests).
tnikolova82
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudfoundry-community/cf-helper-php 1.6.*fromwith_phpredisandwith_amqptest fixtureswith_phpredis/index.phpto connect directly to localhost instead of using CfHelper VCAP_SERVICES parsingProblem
Composer 2.9.8 introduced
block-insecureaudit behavior that blocks packages with known security advisories by default. Thecf-helper-php 1.6.*dependency transitively requires:filp/whoops ~1.1(advisoryPKSA-vbfj-ghxh-xgb7)symfony/yaml ~2.5(advisoriesPKSA-v5yj-8nmz-sk2q,PKSA-ft77-7h5f-p3r6,PKSA-b14r-zh1d-vdrc)This causes
composer installto fail during staging, breaking theapp_with_phpredis_moduleandapp_with_amqp_moduleswitchblade tests.Why removal instead of upgrade
cf-helper-phpis effectively abandoned (last release: Jan 2020)cf-helper-phpfunctionality — they only check that PHP extensions (ext-redis,ext-amqp,ext-igbinary) load correctlywith_amqpfixture never imported cf-helper-php in its code at allwith_phpredisfixture used CfHelper to parse VCAP_SERVICES for Redis connection info, but always falls back to localhost defaults since no Redis service is bound in tests