Unify spelling of "organization" for client certificate metadata verification #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
a18e
changed the title
plowin
approved these changes
Oct 13, 2023
Contributor
There was a problem hiding this comment.
+1 @ameowlia, please check and consider including it before the 0.283.0 to avoid an "incompatibility".
To be merged alongside https://github.com/cloudfoundry/gorouter/pull/368/files
ameowlia
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
cloudfoundry/gorouter#367 and #355 introduced "Optional mTLS client certificate metadata verification".
There were some typos in the yaml/configuration mapping. This PR along with cloudfoundry/gorouter#368 unifies the spelling of "organization" to follow the naming in
pkix.What type of change is this?
[Breaking Change]: the change removes a feature or introduces a behavior change to core functionality (request routing, request logging)[Minor Feature/Improvement]: the change introduces a new feature or improvement that doesn't alter core behavior[Bug Fix]: the change addresses a defectHow should this be tested?
There are no functional changes to the certificate metadata verification feature. Since the feature hasn't been included in a release yet, it's also very unlikely that it is already in use so the configuration change should not affect anyone.
Additional Context
Gorouter PR: cloudfoundry/gorouter#368
PR Checklist
developbranch.