feat: Add route_services_internal_server_port property. #382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Fixes #342
What type of change is this?
[Breaking Change]: the change removes a feature or introduces a behavior change to core functionality (request routing, request logging)[Minor Feature/Improvement]: the change introduces a new feature or improvement that doesn't alter core behavior[Bug Fix]: the change addresses a defectIf you have selected multiple of the above, it may be wise to consider splitting this PR into multiple PRs to decrease the time for minor changes + bugs to be resolved.
Backwards Compatibility
If this is a breaking change, or modifies currently expected behaviors of core functionality (request routing or request logging), how has the change been mitigated to be backwards compatible?
Yes. The port change should be transparent as it is only used internally and only opened on localhost.
Should this feature be considered experimental for a period of time, and allow operators to opt-in? Should this apply immediately to all routing-release deployments?
No.
How should this be tested?
Are there any non-automated tests that should be performed against this change for validation? Please provide steps, and expected results for before + after the change.
Additional Context
Please provide any additional links or context (issues, other PRs, Slack discussions) to help understand this change.
PR Checklist
developbranch.