Skip to content

Conversation

@domdom82
Copy link
Contributor

@domdom82 domdom82 commented Jan 25, 2024

What is this change about?

Fixes #342

  • Removes randomly selected port for internal route service server
  • Sets a dedicated port (default: 7070)

What type of change is this?

  • [Breaking Change]: the change removes a feature or introduces a behavior change to core functionality (request routing, request logging)
  • [Minor Feature/Improvement]: the change introduces a new feature or improvement that doesn't alter core behavior
  • [Bug Fix]: the change addresses a defect

If you have selected multiple of the above, it may be wise to consider splitting this PR into multiple PRs to decrease the time for minor changes + bugs to be resolved.

Backwards Compatibility

If this is a breaking change, or modifies currently expected behaviors of core functionality (request routing or request logging), how has the change been mitigated to be backwards compatible?
Yes. The port change should be transparent as it is only used internally and only opened on localhost.

Should this feature be considered experimental for a period of time, and allow operators to opt-in? Should this apply immediately to all routing-release deployments?
No.

How should this be tested?

Are there any non-automated tests that should be performed against this change for validation? Please provide steps, and expected results for before + after the change.

  • Spec tests have been provided
  • Unit and integration tests have been adjusted in companion PR

Additional Context

Please provide any additional links or context (issues, other PRs, Slack discussions) to help understand this change.

PR Checklist

@domdom82 domdom82 force-pushed the route_service_fixed_port branch from ce02824 to 67412ab Compare January 26, 2024 09:42
@domdom82 domdom82 merged commit f0a9332 into cloudfoundry:develop Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gorouter should use a dedicated port for local route service requests

2 participants