use registry-image as the docker-image resourse is legacy#641
Merged
jochenehret merged 2 commits intocloudfoundry:mainfrom Mar 31, 2026
Merged
use registry-image as the docker-image resourse is legacy#641jochenehret merged 2 commits intocloudfoundry:mainfrom
jochenehret merged 2 commits intocloudfoundry:mainfrom
Conversation
…be used within new concourse 8.x
jochenehret
reviewed
Mar 31, 2026
Contributor
jochenehret
left a comment
There was a problem hiding this comment.
Basically ok, but in a few tasks we likely need to keep the "docker-image" resource for building images.
ci/build-docker-images.yml
Outdated
|
|
||
| - name: relint-base-image | ||
| type: docker-image | ||
| type: registry-image |
Contributor
There was a problem hiding this comment.
I think the "registry-image" resource canNOT be used for building Docker images, only for pulling and pushing. So for the "build-docker-images" pipeline, we should stick to "docker-image"?
Contributor
Author
There was a problem hiding this comment.
you are correct.
This resource does not and will never support building - only registry image pushing/pulling. Building should instead be done with something like the oci-build task (or anything that can produce OCI image tarballs).
Contributor
Author
There was a problem hiding this comment.
reverted the changes for the build pipeline
jochenehret
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the registry-image is replacement for docker-image resource
and the docker-image resources now causes allot of captcha errors to dockerhub