Skip to content

Conversation

@acrmp
Copy link
Contributor

@acrmp acrmp commented Oct 25, 2023

Description

  • Operators are already able to tag emitted log lines with the BOSH Director name with the director structured data parameter.
  • Add a new environment structured data parameter for cases where log lines should be tagged with an operator provided string but need to vary from the director name.
  • Don't add the environment SD-PARAM when the BOSH property is not provided by the operator. This prevents any log parsing breakage that might occur if log processors were to be string matching rather than parsing syslog messages correctly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (included in this PR)

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

acrmp added 2 commits October 25, 2023 02:09
- Operators are already able to tag emitted log lines with the BOSH
  Director name with the `director` structured data parameter.
- Add a new `environment` structured data parameter for cases where log
  lines should be tagged with an operator provided string but need to
  vary from the director name.
- Don't add the environment SD-PARAM when the BOSH property is not
  provided by the operator. This prevents any log parsing breakage that
  might occur if log processors were to be string matching rather than
  parsing syslog messages correctly.
@ctlong ctlong merged commit 9617e56 into cloudfoundry:main Oct 25, 2023
@ctlong ctlong deleted the environment-sd-param branch October 25, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants