Include optional environment identifier #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Operators are already able to tag emitted log lines with the BOSH Director name with the `director` structured data parameter. - Add a new `environment` structured data parameter for cases where log lines should be tagged with an operator provided string but need to vary from the director name. - Don't add the environment SD-PARAM when the BOSH property is not provided by the operator. This prevents any log parsing breakage that might occur if log processors were to be string matching rather than parsing syslog messages correctly. Signed-off-by: Carson Long <lcarson@vmware.com>
ctlong
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
directorstructured data parameter.environmentstructured data parameter for cases where log lines should be tagged with an operator provided string but need to vary from the director name.See also cloudfoundry/syslog-release#153.
Type of change
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack