Skip to content

Conversation

@tylersticka
Copy link
Member

@tylersticka tylersticka commented Jun 22, 2021

Overview

  • Adds and documents has-{font-size}-font-size utilities for the Gutenberg block editor.
  • Exposes more size.font and number.line-height tokens.
  • Moves modular scale logic of heading calculation from Sass mixin to token definition.
  • Rejoins -n-{digit} token names to be -n{digit} for consistency with class names.
  • Fixes a small bug with Gutenberg quotes found along the way.

Screenshots

Screen Shot 2021-06-22 at 2 35 25 PM

Screen Shot 2021-06-22 at 2 35 06 PM

Testing

On the deploy preview

  • Review Design ▸ Typography stories for regressions
  • Review Components ▸ Heading stories for regressions
  • Review Vendor ▸ WordPress ▸ Utilities ▸ Font Size story (try different classes using controls)

  • See cloudfour/cloudfour.com-wp#491

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2021

🦋 Changeset detected

Latest commit: 346ee39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tylersticka tylersticka marked this pull request as ready for review June 22, 2021 21:54
@tylersticka tylersticka requested a review from a team June 22, 2021 21:58
calebeby
calebeby previously approved these changes Jun 23, 2021
Copy link
Member

@calebeby calebeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Co-authored by: Caleb Eby <caleb@cloudfour.com>
@tylersticka tylersticka merged commit f7781a1 into v-next Jun 23, 2021
@tylersticka tylersticka deleted the feature/line-height-tokens branch June 23, 2021 16:03
@github-actions github-actions bot mentioned this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants