Skip to content

Conversation

@tylersticka
Copy link
Member

@tylersticka tylersticka commented Jun 23, 2021

Overview

As part of #1333, I mistakenly thought that WordPress would preserve the structure of slugs as class names, but instead it appears to filter the slugs through a kebab-case function that treats numbers as separate words. For this reason, our Gutenberg font size utilities must output n-2 instead of n2 (and so on).

Testing

Review deploy preview


@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2021

🦋 Changeset detected

Latest commit: 7ee4c75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tylersticka tylersticka marked this pull request as ready for review June 23, 2021 21:47
@tylersticka tylersticka requested a review from a team June 23, 2021 21:47
@tylersticka tylersticka merged commit 92a9bbd into v-next Jun 23, 2021
@tylersticka tylersticka deleted the fix/gutenberg-font-size-class-names branch June 23, 2021 22:14
@github-actions github-actions bot mentioned this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants