Fix issue with Comment replies block not working
#1440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Comment template has a `replies` block allowing devs to customize how replies are output. This block was not working correctly because it was nested inside another embed. This PR uses `set` to define the replies outside of the embed and then pass them in.
🦋 Changeset detectedLatest commit: efd3e74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Paul-Hebert
commented
Jul 23, 2021
| } only %} | ||
| {% endfor %} | ||
| {% endblock %} | ||
| {% endset %} |
Contributor
Author
There was a problem hiding this comment.
I'm open to other ideas if there's a less yucky way to handle this. This needs to be defined after _child_heading_depth is set
tylersticka
approved these changes
Jul 23, 2021
| } only %} | ||
| {% endfor %} | ||
| {% endblock %} | ||
| {% endset %} |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Comment template has a
repliesblock allowing devs to customize how replies are output.This block was not working correctly because it was nested inside another embed.
This PR uses
setto define the replies outside of the embed and then pass them in.