Skip to content

Fix issue with Comment replies block not working #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Fix issue with Comment replies block not working #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95b374c
Fix issue with Comment `replies` block not working
Paul-Hebert Jul 23, 2021
efd3e74
Commit right stuff
Paul-Hebert Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-teachers-roll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@cloudfour/patterns': patch
---

Fix issue with Comment `replies` block not working
25 changes: 17 additions & 8 deletions src/components/comment/comment.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,18 +113,27 @@
<h{{_section_heading_depth}} class="u-hidden-visually">
Replies to {{comment.author.name}}
</h{{_section_heading_depth}}>

{#
This is defined here, so we can pass it into the block of a nested embed.
@see https://benfurfie.co.uk/articles/how-to-nest-a-block-in-another-block-in-an-embed-in-twig
#}
{% set repliesContent %}
{% block replies %}
{% for child in comment.children %}
{% include '@cloudfour/components/comment/comment.twig' with {
comment: child,
heading_depth: _child_heading_depth,
} only %}
{% endfor %}
{% endblock %}
{% endset %}
Copy link
Contributor Author

@Paul-Hebert Paul-Hebert Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to other ideas if there's a less yucky way to handle this. This needs to be defined after _child_heading_depth is set

Copy link
Member

@tylersticka tylersticka Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine 👍


{% embed '@cloudfour/objects/rhythm/rhythm.twig' with {
class: 'c-comment__replies'
} %}
{% block content %}
{% block replies %}
{% for child in comment.children %}
{% include '@cloudfour/components/comment/comment.twig' with {
comment: child,
heading_depth: _child_heading_depth,
} only %}
{% endfor %}
{% endblock %}
{{ repliesContent }}
{% endblock %}
{% endembed %}
{% endif %}
Expand Down