Skip to content

Conversation

@tylersticka
Copy link
Member

Overview

A bug popped up a while ago in the Storybook padding add-on we used, but it's been a challenging issue for the developer to resolve because of some very odd markup structure in Storybook Docs.

Although our add-on supported multiple steps in our modular scale, I realized when looking at the various stories that we were only ever applying or disabling the add-on. This makes the value of the toolbar item questionable compared to the layout feature that Storybook includes, which can be set to fullscreen for stories that are meant to fill the viewport width.

So this PR removes the add-on, and replaces any parameters related to removing padding with layout: 'fullscreen'.


@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2021

⚠️ No Changeset found

Latest commit: 020e8da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 18, 2021

✔️ Deploy Preview for cloudfour-patterns ready!

🔨 Explore the source changes: 020e8da

🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/6196b19e79ed1f00085f7669

😎 Browse the preview: https://deploy-preview-1590--cloudfour-patterns.netlify.app/

@tylersticka tylersticka marked this pull request as ready for review November 18, 2021 20:09
@tylersticka tylersticka requested a review from a team November 18, 2021 20:09
@tylersticka tylersticka merged commit c74ff8b into v-next Nov 18, 2021
@tylersticka tylersticka deleted the chore/remove-paddings branch November 18, 2021 21:44
spaceninja added a commit that referenced this pull request Nov 22, 2021
* v-next:
  Improve themes toolbar, add text flow toolbar (#1592)
  Update dependency @types/jest to v27.0.3
  Update dependency @babel/preset-env to v7.16.4
  Add min-width to Page contents (#1591)
  Remove paddings add-on (#1590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Storybook padding regressions

3 participants