Skip to content

Conversation

@tylersticka
Copy link
Member

Overview

While working on #1576, I realized I didn't have a great method for actually testing that logical properties were applying well across different direction and writing-mode settings. The Storybook add-ons related to this seem pretty far out of date, but then I saw that this was one of the use cases for the global toolbar settings we're already using for themes. I found managing separate toolbars for direction and writing-mode a bit unwieldy, so instead I consolidated these into a "text flow" item.

Along the way, I noticed that our Theme toolbar did not include all of our themes. So I modified it to support t-alternate.

I set showName to true for both of our toolbar items to make them more obvious.

Once I made these changes, I noticed that the logical properties demo for our spacing utilities wasn't quite as useful as seeing how the different settings directly impacted stories. So I removed it.

Screenshots

Screen Shot 2021-11-19 at 4 37 07 PM

Screen Shot 2021-11-19 at 4 37 20 PM

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2021

⚠️ No Changeset found

Latest commit: 23befa4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 20, 2021

✔️ Deploy Preview for cloudfour-patterns ready!

🔨 Explore the source changes: 23befa4

🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/61984439ff05030008d737d2

😎 Browse the preview: https://deploy-preview-1592--cloudfour-patterns.netlify.app

@tylersticka tylersticka marked this pull request as ready for review November 20, 2021 00:45
@tylersticka tylersticka requested a review from a team November 20, 2021 00:45
@calebeby
Copy link
Member

@tylersticka This is probably not related to this PR, but I noticed that in the spacing stories, the text is white-on-white when the theme is set to dark or dark-alt:

screenshot

@tylersticka
Copy link
Member Author

This is probably not related to this PR, but I noticed that in the spacing stories, the text is white-on-white when the theme is set to dark or dark-alt:

Yeah, those demos aren't really using any of our components, and the bespoke demo CSS isn't themed. So not related to this PR, but thanks for calling out!

@tylersticka tylersticka merged commit 99a7da7 into v-next Nov 22, 2021
@tylersticka tylersticka deleted the feature/improve-storybook-toolbar branch November 22, 2021 18:10
spaceninja added a commit that referenced this pull request Nov 22, 2021
* v-next:
  Improve themes toolbar, add text flow toolbar (#1592)
  Update dependency @types/jest to v27.0.3
  Update dependency @babel/preset-env to v7.16.4
  Add min-width to Page contents (#1591)
  Remove paddings add-on (#1590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants