Skip to content

Conversation

@tylersticka
Copy link
Member

Overview

This PR resolves two Sass deprecation warnings:

Note

This PR does not resolve all deprecation warnings, only the two listed above.

Testing

Confirm there's no change in the output CSS. For example, from the project directory:

  1. Checkout the main branch: git checkout main
  2. Pull the latest: git pull
  3. Install dependencies: npm ci
  4. Build the CSS: npm run build:sass
  5. Observe that the output includes Sass deprecation warnings for [color-functions] and [import].
  6. Move the output to a new directory: mv dist dist-before
  7. Checkout this PR branch: git checkout chore/sass-warnings
  8. Build the CSS again: npm run build:sass
  9. Observe that the output no longer includes Sass deprecation warnings for [color-functions] or [import].
  10. Compare the before and after files: diff dist/standalone.css dist-before/standalone.css (there shouldn't be any output since there are no differences)
  11. Remove the dist-before directory (so you don't accidentally commit it later): rm -rf dist-before

@netlify
Copy link

netlify bot commented May 23, 2025

Deploy Preview for cloudfour-patterns ready!

Name Link
🔨 Latest commit 6e9022f
🔍 Latest deploy log https://app.netlify.com/projects/cloudfour-patterns/deploys/6830da07c88e630007d244a2
😎 Deploy Preview https://deploy-preview-2289--cloudfour-patterns.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tylersticka tylersticka marked this pull request as ready for review May 23, 2025 20:29
@tylersticka tylersticka requested a review from a team May 23, 2025 20:29
@tylersticka tylersticka merged commit 69dcc17 into main May 27, 2025
10 checks passed
@tylersticka tylersticka deleted the chore/sass-warnings branch May 27, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve Sass deprecation warning: import Resolve Sass deprecation warning: color-functions

3 participants