Feature: Attach baseurl property to template context#92
Merged
Conversation
Member
|
This sounds a lot more difficult than the code makes it look! |
| import path from 'path'; | ||
| import { pathSatisfies, is } from 'ramda'; | ||
|
|
||
| function getBaseUrl (resource, drizzleData) { |
Member
There was a problem hiding this comment.
Any chance we can get documentation? :)
Member
|
Looks good @erikjung! Yes, it does sound difficult. :) Do we need to worry about writing any test for this at all? Otherwise, LGTM! 👍 |
3 tasks
Contributor
Author
|
@mrgerardorodriguez
I realized that I didn't acknowledge this. Yes, there should eventually. The tests are going to get a big refactor soon. |
This was referenced May 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #63, cloudfour/drizzle#43
This change makes the
{{baseurl}}template property have a value.The value will be different depending on the location of each page, and will always be a relative path string pointing to the destination root directory (e.g.
dist).For example:
This will allow the static HTML output to be viewed using the
file://protocol without needing any server:/CC @tylersticka @saralohr @nicolemors @aileenjeffries